1. Gallery Field for photos that each user can upload when logged in and view is public

Create a gallery field type then disable all media types other than photos. Leave the rest of the parameters as is.

2. Gallery field for files that each user can upload but is private

Create a gallery field type then disable all media types other fan files. Leave the rest of the parameters as is. Next using CB Privacy under Integrations > Privacy set "Display" to "Forced privacy control" and "Default" to "Private".

That's all you should have to do unless you've altered the global parameters and if you did you'll need to adjust more specifically each fields parameters.

3. Joomla menu items for both

This is a bit trickier. Menu items will not inherit the fields parameters. In fact it will override them given the chance. So what you need to do is create a Joomla menu item with menutype Community Builder > Plugin and select CB Gallery as the Plugin. Now you need to replicate the parameters you set in the field also in the menu item (e.g. disable all types except photos). Now in order for it to output the fields entries the most important parameter is Asset. Asset determines location. The asset, by default, for fields is profile.PROFILE_ID.field.FIELD_ID. So you'll need to use profile.[user_id].FIELD_ID to do this dynamically (replace FIELD_ID with the actual field id).

4. Tab in profile for both

As they're already fields you shouldn't need to do anything specific for this beyond put them on their respective tabs.

I have this for the documents already [user_id].field.93
This for photos [user_id].field.245

Neither of those are correct. They are as follows to match a fields default asset. See my above reply for further asset usage details as well as the asset parameter description.

profile.USER_ID.field.FIELD_ID

So in your case the assets to those 2 fields would be used as follows.

profile.[user_id].field.93
profile.[user_id].field.245

If you changed the assets of the field or the global CB Gallery parameters there is not much I can do to help you as I can not personalize examples, sorry. You will need to review your own configuration carefully if that is the case.