Hi,

I installed the new CB 1.1 and everything runs well except for the way tabs are displayed in IE7.

Lets say I have 8 tabs.

When I view "my profile" page in IE7 I see all content of all tabs displayed. When I click the 2nd tab IE7 shows all tabs except the first. Clicking the 3rd leaves out the second one and so on until I reach number 8 causing it to only display the last.

After clicking number 8 all tabs are shown correctly.

This only happens in IE7 in FF its ok. Ohw and below the mainbody part of the template the template also get messed up. Could there some code be missing or....

I just don't understand and it;s costing me way to much time to figure this one out. So I hope someone can help me here.

Thanks!

Jaap

Hi Beat,

First of all thanks for your reply..... BUT

I ran my template at W3.org and it comes out without any errors after making some minor changes. However I then ran the result of the page (source) again at W3 and have been busy since to correct all the issues mentioned in the output including all errors that are applicable to CB itself(!!) and all modules the customer runs.

In the end I solved the issue that was caused by wrong CSS code. I replaced the css file with the origional and discovered it was working fine. So I must have deleted something by accident.

Anyway the page returns without any errors now but I still have a problem at the view profile page and the list profiles page.(when updating the profile the problem is not there)

To demonstrate the problem I included some screenprints to demonstrate.

If you take a look at the 1st screenprint (correct.jpg) you'll see the bottom-right module displayed the way I expected it and is at all except the two mentioned screens.

When looking at screenprint 2 (incorrect.jpg) you will see that the bottomright module is now a little out of place but a little to much for me

Can you point me out:
1. Why this only happens in the 2 CB screens mentioned
2. How to solve this

Regards,

Jaap

Hi Beat,

First of all deleting the text you mentioned is not the solution as it is messed up in both IE and FF after that. So I putted it back in.

About the compliance issues: Sure no problem I like community spirit

Everything below is according to the W3 site and are mostly minor things. Lots of plugins are worse, believe me, as they took most of the time. So this goes out to all you programmers out there(!)

Here are a few things that are incorrect according to the W3 site. Because they are all over the several programs of CB I will just name a few general things so you can search on it in the file:

It's not allowed to use a single "&" in url statements this should be "& amp;" (without the whitespace of course ) so this goes for almost every url in the code of cb (e.g com_profiler&task etc)

There are a lot of places where the "<img" tag is not closed and where a / needs to be added at the end right before >.

At a lot of places where a preset color is applicable the color is defined like color=red which is ok for php if you have turned on the according options but according to W3 it should be: color="red" or in most cases in the code written with ' for obvious reasons.

I can't recall where (sorry, busy) but there is a place in the code where a java script is called and where type="text/javascript" has to be added.

In the profile gallery plugin there is also an error concerning the use of "< br />" in the title attribute of the image shown which is not allowed. This should be "& lt;br />" or even better:"& lt;br /& gt;"

An other common made mistake (big word for small things:unsure: ) in the plugins is the way the css is applied because the <link ... is not allowed at the location it's at. It would be better to use the $mainframe->addCustomHeadTag() function adding the css to the head section of the page.

And there are more but I think it would be wise that all programmers would do check their code against W3 and not only their code but also their code when used in a CB operative site don't you think?

Ohw and while they are doing that why not write the componentheading at the top of the page where it belongs instead of below all kind of stuff displayed above it. I changed all those lines (there also some without the inner div):

[code:1]
<table cellspacing="0" cellpadding="4" border="0" width="100%">
<tr>
<td colspan="6"><div class="componentheading"><?php echo $title; ?></div></td>
</tr>
</table>
[/code:1]

with the following line:

[code:1]
<div class="componentheading"><?php echo htmlspecialchars( $title ); ?></div>
[/code:1]

and placed it right on top of the page where applicable. I also added some styling to some screens where there was none like password change, email and so on. Most of this is done in comprofiler.html.php.

I noticed that sometimes there is htmlspecialchars() added to some titles. I was wondering: "Why some and not all (not)?"

Yeah I know why all the fuss about styling well I'm a designing programmer or programming designer if you like and personally I think to litte is done by a lot of programmers to have things look nice and work in a consistent way As a result of this numerous people are do all the same effort to a chief just that. Consuming tremendous amounts of time world wide....

You know I think I might as well include my version of the comprofiler.html.php file so you can try/see for yourself if it could be an addition to CB.

Anyway to conclude this somewhat long reply (for which I'm sorry but wouldn't waste the effort of typing it by deleting some. )

Regards,

Jaap

Post edited by: jaap_a, at: 2007/09/07 03:24

Post edited by: jaap_a, at: 2007/09/07 03:27

well here is the file