 |
|
Re:removing filters in list
|
|
Date: 2008/12/21 00:33
|
By: ndee
|
Status: 
|
|
|
Karma: 16
|
|
Platinum Joomlapolitan
| Posts: 505 |   |
|
|
It did not stop bother me... 
I hope it is fixed. Please check. Beside the fix of the Remove function I added a missing space to the select list and some double qoutes and the fitler -> filter typo.
All line numbers refer to admin.comprofiler.html.php shipped with CB 1.2 RC4.
I rewrote moveOption4 because it did not make sense:
a) second param was never used
b) for loop was useless and got never executed
c) the function does only cut of the last element of the array
I have not much experience with Javascript so please check if the function works right.
removed line 587-604
| Code: |
function moveOption4(fromObj, toObj)
{
for(var i = fromObj.options.length - 1; i >= 0; i--)
{
if(fromObj.options[i].selected)
{
fromObj.options[i].selected = false;
for(var j = i; j < fromObj.options.length - 1; j++)
{
fromObj.options[j].text = fromObj.options[j + 1].text;
fromObj.options[j].value = fromObj.options[j + 1].value;
}
fromObj.options.length = fromObj.options.length - 1;
if(NS4)
history.go(0);
}
}
}
|
added:
| Code: |
function moveOption4(fromObj)
{
fromObjIndex = fromObj.selectedIndex;
fromObj.options[fromObjIndex].selected = false;
fromObj.options[fromObjIndex] = null;
}
|
----
function getFilterList(selectObj); line 624-652
added else statement to make sure the variable filterfields is empty, without doing that it is not empty if you remove the last filter
| Code: |
function getFilterList(selectObj) {
var filterfields='';
var j=0;
var advType=getObject('ft2');
var simType=getObject('ft1');
//alert(simType.checked);
if(simType.checked) {
selectAll(selectObj);
if(selectObj.selectedIndex != -1) {
for(i = 0; i < selectObj.options.length; i++) {
if(j>0) filterfields += ' AND ';
filterfields += selectObj.options[i].value;
j++;
}
//alert(filterfields);
if(filterfields!="") {
document.adminForm.filterfields.value="s("+filterfields+")";
} else {
document.adminForm.filterfields.value="";
}
}
} else {
if(document.adminForm.advFilterText.value!="") {
document.adminForm.filterfields.value="a("+escape(document.adminForm.advFilterText.value)+")";
} else {
document.adminForm.filterfields.value="";
}
}
}
|
added else clause
| Code: |
function getFilterList(selectObj) {
var filterfields='';
var j=0;
var advType=getObject('ft2');
var simType=getObject('ft1');
//alert(simType.checked);
if(simType.checked) {
selectAll(selectObj);
if(selectObj.selectedIndex != -1) {
for(i = 0; i < selectObj.options.length; i++) {
if(j>0) filterfields += ' AND ';
filterfields += selectObj.options[i].value;
j++;
}
//alert(filterfields);
if(filterfields!="") {
document.adminForm.filterfields.value="s("+filterfields+")";
} else {
document.adminForm.filterfields.value="";
}
} else {
document.adminForm.filterfields.value="";
document.adminForm.advFilterText.value="";
}
} if(advType.checked) {
if(document.adminForm.advFilterText.value!="") {
document.adminForm.filterfields.value="a("+escape(document.adminForm.advFilterText.value)+")";
} else {
document.adminForm.filterfields.value="";
}
}
}
|
---
line 892, changed function call
| Code: |
<input type=button onclick="moveOption4(this.form.filter,this.form.filterfieldlist);" value=" Remove ">
|
to
| Code: |
<input type=button onclick="moveOption4(this.form.filter);" value=" Remove " />
|
minor changes in enclosed admin.comprofiler.html.php
Post edited by: ndee, at: 2008/12/21 00:51
###################
SPEED UP HELP, read first: Help us help you
###################
|
|
The topic has been locked. |
|
|
