#3081 Profile Update Logger & empty Date fields

12 years 4 months ago - 12 years 4 months ago #184739 by MasterNABO
Joomla 1.5.25
CB 1.7.1
CB Profile Update 1.2
Xref: forge.joomlapolis.com/boards/35/topics/1706

Hi Nant

When I amended cb_addr2 and clicked Update to test CB Profile Update Logger, it also incorrectly logged three date fields cb_famjoined2,3,4. These are fields that have been set up to be filled by CB Subs when a family member joins. At the moment the user in question has one family member, with a valid date, so cb_famjoined1 was not displayed. cb_famjoined1,2,3 are empty fields with no date entered yet.
A second test, opening the profile for Update, making no changes and then clicking Update to simulate no change made (I know Cancel should be used, but users may not think to do so) also precipitates 3 incorrect errors (see below).

This plugin is very good and particularly important at this stage of my website development as I expect many user profile updates that need to be monitored to keep the off-line and on-line membership systems in step. However, this is going to be a major problem, generating many false positives, which I hope you can easily fix.

Output on the User Profile Update Log:
2011-12-08 09:43:56 cb_famjoined4 0000-00-00 1,62(web)
2011-12-08 09:43:56 cb_famjoined3 0000-00-00 1,62(web)
2011-12-08 09:43:56 cb_famjoined2 0000-00-00 1,62(web)
2011-12-08 00:57:24 cb_famjoined4 0000-00-00 1,62(web)
2011-12-08 00:57:24 cb_famjoined3 0000-00-00 1,62(web)
2011-12-08 00:57:24 cb_famjoined2 0000-00-00 1,62(web)
2011-12-08 00:57:24 cb_addr2 Great Bourtod Great Bourton 1,62(web)
2011-12-08 00:56:16 cb_famjoined4 0000-00-00 1,62(web)
2011-12-08 00:56:16 cb_famjoined3 0000-00-00 1,62(web)
2011-12-08 00:56:16 cb_famjoined2 0000-00-00 1,62(web)
2011-12-08 00:56:16 cb_addr2 Great Bourton Great Bourtod 1,62(web)

Thanks
John

Please Log in to join the conversation.

12 years 4 months ago #184741 by nant
I am not sure I can do anything about this - the actual data did change for these dates, most likely from null to 0 date value as you can see.

Please Log in to join the conversation.

12 years 4 months ago #184743 by MasterNABO
Replied by MasterNABO on topic Re: Profile Update Logger & empty Date fields
Not true, as you could have seen more clearly if the Forum hadn't reformatted the output!
The 0000-00-00 entry is in the Old Value Column. The blank (null?) appears in the New Value Column.
If your assertion was true, the extra 3 entries would have appeared only once. The fact that they appear each time implies to me that the data has not changed but that Profile Update Logger thinks it has.
Looks like the logic is testing against slightly different data formats in the Old Value and New Values for dates?

Please Log in to join the conversation.

12 years 4 months ago #184787 by nant

Please Log in to join the conversation.

12 years 2 months ago #191737 by MasterNABO
Replied by MasterNABO on topic Re: Profile Update Logger & empty Date fields
Any progress on this, please, Nick? Now that I have uploaded all our members' details to the website I'm getting lots of false positives, which is confusing for my members.

You posted a simple filter fix on forge.joomlapolis.com/issues/3081:
if (($oB->$sKey != "0000-00-00") AND ( $oA->$sKey != null )) { // empty date exception
$retArr[] = array($sKey, $oB->$sKey, $oA->$sKey);
}

Did it work? If so, can I apply it and where?

Please Log in to join the conversation.

12 years 2 months ago #191746 by nant

Big_John wrote: Any progress on this, please, Nick? Now that I have uploaded all our members' details to the website I'm getting lots of false positives, which is confusing for my members.

You posted a simple filter fix on forge.joomlapolis.com/issues/3081:
if (($oB->$sKey != "0000-00-00") AND ( $oA->$sKey != null )) { // empty date exception
$retArr[] = array($sKey, $oB->$sKey, $oA->$sKey);
}

Did it work? If so, can I apply it and where?


The fix should work.
I updated the ticket with more info about fix.

I will be pushing a new version out later this week.
The following user(s) said Thank You: MasterNABO

Please Log in to join the conversation.

Moderators: beatnantkrileon
Time to create page: 0.207 seconds

Facebook Twitter LinkedIn