Your sematic is just AWFUL

12 years 2 weeks ago #112942 by Castor
Your sematic is just AWFUL was created by Castor
I like this component/module/plugin very very much because I can't write any php or java code.
So i am pleased to use your code.

Waht i can do is designing and coding HTML and CSS. And what I have to see in your HTML Code is just AWFUL :sick:

I myself would like to use CB, but i will not use it with THIS KIND of Code...

I wouldn't even write here if I didn't want to use CB.
So i have 2 Question: Plz tell me, where in the PHP Code i can modify the HTML parts (i will also post them here to help you improving the sematic) and the second question is just: Improve this code.

So now i talked much and now the facts. Watch at this guys. that's the Code of the CB login module of THIS SITE HERE (similar to all the other CB sites)

[code:1]
<div class="module">
<div>
<div>
<div>
<h3>CB Login</h3>
<form id="mod_loginform" style="margin: 0px;" method="post" action=" www.joomlapolis.com/component/option,com_comprofiler/task,login/ ">
<table class="mod_login" cellspacing="0" cellpadding="0" border="0" width="100%">
<tbody>
<tr>
<td>
<span id="mod_login_usernametext">
<label for="mod_login_username">
<img height="20px" width="25px" alt="Username or email" src=" www.joomlapolis.com/modules/mod_cblogin/username.png"/ >
Username or email
</label>
</span>
<br/>
<input id="mod_login_username" class="inputbox" type="text" size="14" name="username"/>
<br/>
<span id="mod_login_passwordtext">
<label for="mod_login_password">
<img height="20px" width="25px" alt="Password" src=" www.joomlapolis.com/modules/mod_cblogin/password.png"/ >
Password
</label>
</span>
<br/>
<span>
<input id="mod_login_password" class="inputbox" type="password" size="14" name="passwd"/>
</span>
<br/>
<input type="hidden" value="login" name="op2"/>
<input type="hidden" value="english" name="lang"/>
<input type="hidden" value="1" name="force_session"/>
<input type="hidden" value="B:aHR0cDovL3d3dy5qb29tbGFwb2xpcy5jb20vaW5kZXgucGhwP29wdGlvbj1jb21fam9vbWxhYm9hcmQmYW1wO0l0ZW1pZD0zOA==" name="return"/>
<input type="hidden" value="0" name="message"/>
<input type="hidden" value="loginmodule" name="loginfrom"/>
<input type="hidden" value="cbm_0cfe17b1_65128d21_2ae2614cbca37b464257bb5fab823fe0" name="cbsecuritym3"/>
<input type="hidden" value="1" name="j5a5a11797b0164d964fdfc8a856cbf89"/>
<input id="mod_login_remember" type="checkbox" value="yes" name="remember"/>
<span id="mod_login_remembermetext">
<label for="mod_login_remember">Remember me</label>
</span>
<br/>
<input class="button" type="submit" style="min-height: 20px; padding-left: 30px; cursor: pointer; background-image: url( www.joomlapolis.com/modules/mod_cblogin/login.png ); background-position: 0pt 0pt; background-repeat: no-repeat; width: auto;" value="Login" name="Submit"/>
</td>
</tr>
<tr>
<td>
<a class="mod_login" href=" www.joomlapolis.com/component/option,com_comprofiler/task,lostPassword/ ">
<img height="20px" width="25px" style="border-width: 0px; cursor: pointer;" title="Login reminder" alt="Login reminder" src=" www.joomlapolis.com/modules/mod_cblogin/forgot.png"/ >
Forgot login?
</a>
</td>
</tr>
<tr>
<td>
<a class="mod_login" href=" www.joomlapolis.com/component/option,com_comprofiler/task,registers/ ">
<img height="20px" width="25px" style="border-width: 0px; cursor: pointer;" title="Register" alt="Register" src=" www.joomlapolis.com/modules/mod_cblogin/register.png"/ >
Register
</a>
</td>
</tr>
</tbody>
</table>
</form>
</div>
</div>
</div>
</div>
[/code:1]

That makes me sick...
It's not only that the sematic is not correct. NO TABLES SHOULD BE USED FOR SUCH A FUNCTION. No, but also there are about 50% (i'm sorry) bullshit^^ apart from this there ARE ALSO STYLE ATTRIBUTES IN THE TEXT ITSLEF. omg just my biggest nightmare^^

I really don't want to blame you. I DO like CB and THAT is why i really want you to know that your code needs some improvment^^


greez Castor :evil:

Post edited by: Castor, at: 2009/10/02 20:16

Please Log in to join the conversation.

12 years 2 weeks ago #112980 by Castor
Replied by Castor on topic Re:Your sematic is just AWFUL
Together with a PHP Progger i could optimize the code.
WHO WANT?

Please Log in to join the conversation.

11 years 10 months ago #117960 by hivver
Replied by hivver on topic Re:Your sematic is just AWFUL
Hi im not a php coder really but i can do what you need, the html parts in the php code are really into different lines and they are mixed up with the logic, wich is a little different between the plugins in cb.

I have changed some stuff in the plugins and the core before so tell me if you want to do this thing.

hivver at msn.com

I totally agree the output code seems very complex for what it actually do.

Please Log in to join the conversation.

11 years 10 months ago #118579 by krileon
Replied by krileon on topic Re:Your sematic is just AWFUL
The login module is far more then a login module. None of CBs HTML is just plainly outlined as many of it is mixed in with PHP. I don't understand what your complaint is with the HTML? Care to elaborate? The module is due for a re-write possibly in the near future, but for the time being it functions perfectly fine and passes web standard validation.


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in to join the conversation.

Moderators: beatnantkrileon
Time to create page: 0.168 seconds

Facebook Twitter LinkedIn