Joomla 1.09 breaks uddeIM, or is it me?

17 years 10 months ago #14950 by Goob
I found this - it's not the idea fix but until other components get it correct in 1.09....

includes/frontend.php

/**
* Cache some modules information
* @return array
*/
function &initModules() {
global $database, $my, $Itemid;

if (!isset( $GLOBALS )) {
$query = "SELECT id, title, module, position, content, showtitle, params"
. "\n FROM #__modules AS m"
. "\n INNER JOIN #__modules_menu AS mm ON mm.moduleid = m.id"
. "\n WHERE m.published = 1"
. "\n AND m.access <= '". $my->gid ."'"
. "\n AND m.client_id != 1"
. "\n AND ( mm.menuid = '". $Itemid ."' OR mm.menuid = 0 )"
. "\n ORDER BY ordering";

$database->setQuery( $query );
$modules = $database->loadObjectList();
foreach ($modules as $module) {
$GLOBALS[$module->position][] = $module;
}
}
return $GLOBALS;
}

Quoting Stingrey:

Are there consequences to changing this part of the frontend.php in terms of security or stability?

No there is not.


The change was made to correct the value check, to ensure the correct variable type of mm.menuid
mm.menuid is an integer variable, using quotes can slow the query very very slightly as the use of quotes changes the value to a string value rather than an integer value.

However, it seems some components are not correctly returning any Itemid value, thuis resulting in the check being
mm.menuid = OR mm.menuid = 0
which causes an error in the query

The query can however handle a case where the query is
mm.menuid = '' OR mm.menuid = 0


Hope that helps

www.joomlaportal.de/215915-post28.html
forum.joomla.org/index.php/topic,67115.0.html

Post edited by: Goob, at: 2006/06/08 20:43

Please Log in to join the conversation.

17 years 10 months ago #15083 by andyahoo
Replied by andyahoo on topic Re:Joomla 1.09 breaks uddeIM, or is it me?
Goob wrote:

uddem.php
change:
$sql="SELECT id FROM #__menu WHERE link LIKE '%com_uddeim%' AND published>=0 LIMIT 1";


To:
$sql="SELECT id FROM #__menu WHERE link LIKE '%index%' AND published>=0 LIMIT 1";

;)


About what line is that code on?

Raj, did you get this fixed?

Post edited by: andyahoo, at: 2006/06/11 03:23

Joomla! 1.0.9
CB 1.0

Please Log in to join the conversation.

17 years 10 months ago #15113 by Raj
Nope, that fix didn't work for me. Not sure why it would work for some people and not others...that seems especially mysterious. Might have to do with what other messaging components are published/unpublished. I think I upgraded at some point, and maybe parts of UDDEIM .4 are hanging around. I haven't had time to investigate it. Someone needs to say, "Okay, in order for UDDEIM to work, you need this, this, and that, and nothing else." Then we could delete any redundant ones.

If this is a sourceforge project, then more info might be at their project site. Someone needs to register a bug report.

Raj

Please Log in to join the conversation.

17 years 10 months ago #15114 by Raj
That's Line 104 in uddeim.php

By the way, check out Notepad++ for quick editing...you can get it at Download.com. Absolutely free. Totally rules. I use nothing else now.

Raj

Please Log in to join the conversation.

17 years 10 months ago #15115 by andyahoo
Replied by andyahoo on topic Re:Joomla 1.09 breaks uddeIM, or is it me?
Thanks,

By the way, I got this error on a brand new site with fresh installs of all the latest programs:

Joomla 1.0.9
CB 1
the newest uddiem component and mods. (uddiem 5b)

Joomla! 1.0.9
CB 1.0

Please Log in to join the conversation.

17 years 10 months ago #15116 by Raj
Wow, that argues that UDDEIM is indeed broken under 1.09.

I emailed the address in the readme file a few days ago, referencing this thread. No response yet.

I searched SourceForge just now for UDDEIM and found nothing.

I searched the Joomla forums just now and found a thread in a foreign language also suggesting the change at line 104, but nothing else.

I don't know...guess we wait for Benjamin to respond.

Raj

Please Log in to join the conversation.

Moderators: beatnantslabbikrileon
Time to create page: 0.268 seconds

Facebook Twitter LinkedIn