[#1616] Manag. Plugin>Install plugin>Alert error

14 years 1 month ago #127475 by alakentu
When installing CB 1.2.2 and tour the different labels of administration could see that in the "Management Plugin" was an error in the load function package files from directories.

The warning popup does not work or does not appear in IE 8 the error is displayed and click on install from directory button does not work.

In Firefox 3.6 No error displays, but when I click the install button shows me an error saying that the variable "CBTxt::T" is not defined.

The error is found in the file "admin.comprofiler.html.php" near line #3197 in function, "function submitbutton3".

The code is this:
[code:1] function submitbutton3(pressbutton) {
var form = document.adminForm_dir;

// do field validation
if (form.userfile.value == ""«»){
alert(CBTxt::T('Please select a directory'));
} else {
form.submit();
}
}[/code:1]
I changed the alert:
[code:1] function submitbutton3(pressbutton) {
var form = document.adminForm_dir;

// do field validation
if (form.userfile.value == ""«»){
alert('<?php echo CBTxt::T('Please select a directory');?>');
} else {
form.submit();
}
}[/code:1]
Already with this small change I get an alert popup if I do not choose an installation directory, the directory can choose to install any plugin perfectly in both IE and Firefox.

I hope this is helpful to everyone. And excuse my english is not very good.

Best regards and have a good day.

Post edited by: krileon, at: 2010/03/22 15:46

Please Log in to join the conversation.

14 years 1 month ago #127615 by krileon
Thank you for your contribution. Have created a bug ticket for this issue so it maybe addressed properly.

#1616


Kyle (Krileon)
Community Builder Team Member
Before posting on forums: Read FAQ thoroughly + Read our Documentation + Search the forums
CB links: Documentation - Localization - CB Quickstart - CB Paid Subscriptions - Add-Ons - Forge
--
If you are a Professional, Developer, or CB Paid Subscriptions subscriber and have a support issue please always post in your respective support forums for best results!
--
If I've missed your support post with a delay of 3 days or greater and are a Professional, Developer, or CBSubs subscriber please send me a private message with your thread and will reply when possible!
--
Please note I am available Monday - Friday from 8:00 AM CST to 4:00 PM CST. I am away on weekends (Saturday and Sunday) and if I've missed your post on or before a weekend after business hours please wait for the next following business day (Monday) and will get to your issue as soon as possible, thank you.
--
My role here is to provide guidance and assistance. I cannot provide custom code for each custom requirement. Please do not inquire me about custom development.

Please Log in to join the conversation.

14 years 1 month ago #127622 by alakentu
Hi @krileon

I have found that by using the tools of the component in this case the tool "Check CB plugins database" the result is shown complete whole and in version 1.2.1 (no strings translation) shows hidden until we do click on "Click here to show details", this does not work, because the result is printed automatically.

The original code in admin.comprofiler.html.php File version 1.2.2 is this:

[code:1]$_CB_framework->outputCbJQuery( "$('#cbdetailsdbcheck_" . $jsId . "').hide(); $('#cbdetailsLinkShow_" . $jsId . "').click( function() { $('#cbdetailsdbcheck_" . $jsId . "').toggle('slow'); $('#cbdetailsLinkShow_" . $jsId . "').html( $('#cbdetailsLinkShow_" . $jsId . "').html() == CBTxt::T('Click here to Show details') ? CBTxt::T('Click here to Hide details') : CBTxt::T('Click here to Show details') ); return false; } );"«»);[/code:1]

In version 1.2.1 is this:

[code:1]$_CB_framework->outputCbJQuery( "$('#cbdetailsdbcheck_" . $jsId . "').hide(); $('#cbdetailsLinkShow_" . $jsId . "').click( function() { $('#cbdetailsdbcheck_" . $jsId . "').toggle('slow'); $('#cbdetailsLinkShow_" . $jsId . "').html( $('#cbdetailsLinkShow_" . $jsId . "').html() == 'Click here to Show details' ? 'Click here to Hide details' : 'Click here to Show details' ); return false; } );"«»);[/code:1]

If I remove the strings of translation and I regressed to version 1.2.1 code function works correctly.

Please could you take this into account? Thanks and best regards.

Please Log in to join the conversation.

14 years 1 month ago #127679 by beat
Thank you alakentu :)

Not only did you find 2 bugs, but also provided troubleshootings and fix proposal.

Both are linked back in issue:
#1616

With over 1200 strings in backend being translated, and despite source-code review and tests it happens that bugs slip trhough...

Thanks again, great example on how we love bug reports B)

Beat - Community Builder Team Member

Before posting on forums: Read FAQ thoroughly -- Help us spend more time coding by helping others in this forum, many thanks :)
CB links: Our membership - CBSubs - Templates - Hosting - Forge - Send me a Private Message (PM) only for private/confidential info

Please Log in to join the conversation.

14 years 1 month ago #127810 by alakentu
Thanks for your support Beat.

Component will continue to monitor for errors to try to resolve them and thus improve the component so that it remains the number 1 in your area. ;)

Best regards.

Please Log in to join the conversation.

Moderators: beatnantkrileon
Time to create page: 0.241 seconds

Facebook Twitter LinkedIn