module suffix - class and id attributes (css)

14 years 2 weeks ago #126209 by dbrenck
Hi.

Moduleparameters enable the setting of a "module class suffix".
Some component provider additionally added a "module id suffix" to make a clean cut between suffix usage in class="..." arguments and suffix usage in id="..." arguments.
The community builder login module does neither make this difference nor does it consequently use the "module class suffix" only in class attributes.

The reason for my suggestion is a proper usage of css class and id attributes. Imagine the following:

'module class suffix' = " cblogin"

Notice the space before login. This currently resutls in:

<div class="moduletable cblogin">
<h3>Login</h3>
<form action="..." method="post"
id="mod_loginform cblogin"
style="margin:0px;">

Notice class attributes and id attributes.

Maybe it's possible to have this additional "module id suffix" and a proper difference between suffix usage in class and id attributes. This would help much in adjusting "community builder style" to "corporate identities" etc.

Moving the "style" attributes to css files would be helpful as well...

Last thing is the table layout. I don't really care about that, as using display="block" gives the same oppotunities like "div" tags.
The point where I try to take you is a load of <br /> tags in a table cell!
Please! Make use of a clean table without <br /> tags or use a proper stylesheet.

I would appreciate if you consider my suggestions as it would make adjustments much easier of your great component and module.

Please Log in to join the conversation.

Moderators: beatnantkrileon
Time to create page: 0.129 seconds

Facebook Twitter LinkedIn