#145 removing filters in list

10 years 11 months ago #81611 by leblancs
I've stumbled upon a bug in the member list tab when removing an existing filter:



When I attempt to remove the filter, it seems to be removed but upon saving and returning, part of the filter remains. Each time I try to remove the filter and come back, the string gets more and more messed up. It seems that editing it in "Advanced" rather than "Simple" clears everything up though.

-Matt

Post edited by: leblancs, at: 2008/12/08 21:49

EDIT: added #145 (very low priority)

Post edited by: beat, at: 2008/12/19 20:23
Attachments:
10 years 11 months ago #81639 by ndee
Haha!

I forgot it already but I posted this bug some month ago. Maybe devs should open a bugtracker or something like that. Many bugs get lost in deep space forums ;)

www.joomlapolis.com/component/option,com_joomlaboard/Itemid,38/func,view/catid,43/id,62624/#62624

Greets,
ndee

###################
SPEED UP HELP, read first: Help us help you
###################
10 years 11 months ago #81650 by beat
Indeed a very old bug.

We have an internal tracker, no worries, even more of them LOL...

We got an item for that: "Rewrite it with new UI"...for CB 1.3 ;)

However as that javascript code is due for a rewrite in next CB 1.3, and i spent a few hours trying to reproduce the bug without success, and then tried to figure out what could go wrong there.

Will gladly take any fix proposal for this problem...

Workaround is to create another filter, then delete that one. In worst case, go and edit the database entry for that to empty string then redo. Or redo the list.

It's a bug which is very old and happens seldomly...

Now that you gave link on how to reproduce (i missed that one sorry), maybe we can give it another try... ID: #123

Beat - Community Builder Team Member

Before posting on forums: Read FAQ thoroughly -- Help us spend more time coding by helping others in this forum, many thanks :)
CB links: Our membership - CBSubs - Templates - Hosting - Forge - Send me a Private Message (PM) only for private/confidential info
10 years 11 months ago #81667 by ndee
not the bug but related to the list/filter options
line 890 in admin.comprofiler.html.php
[code:1]<input type=button onclick="moveOptions(fitler, 1);" value=" - " />[/code:1]

should be
[code:1]<input type=button onclick="moveOptions(filter, 1);" value=" - " />[/code:1]

Post edited by: ndee, at: 2008/12/09 00:35

###################
SPEED UP HELP, read first: Help us help you
###################
10 years 11 months ago #81674 by ndee
it seems that the function only strips out the filter until the special char "!"

note: i tried above error on field "username" with filter option "NOT EQUAL TO"

after adding the filter in advanced view it looks like:
[code:1]`username` !='myname'[/code:1]

after saving and selecting it in simple view and hitting "remove" button and saving again it looks like
[code:1]sername` !='myname[/code:1]

(Note: when deleting in advanced mode it works)

line 587: admin.comprofiler.html.php
this is the method called on line 892 via js but I do not really understand what it does and where it fails
[code:1]function moveOption4(fromObj, toObj)
{
for(var i = fromObj.options.length - 1; i >= 0; i--)
{
if(fromObj.options.selected)
{
fromObj.options.selected = false;
for(var j = i; j < fromObj.options.length - 1; j++)
{
fromObj.options[j].text = fromObj.options[j + 1].text;
fromObj.options[j].value = fromObj.options[j + 1].value;
}
fromObj.options.length = fromObj.options.length - 1;
if(NS4)
history.go(0);
}
}
}[/code:1]

maybe you know, will check back tomorrow if time is left

###################
SPEED UP HELP, read first: Help us help you
###################
10 years 11 months ago #81685 by beat
ndee wrote:

not the bug but related to the list/filter options
line 890 in admin.comprofiler.html.php
[code:1]<input type=button onclick="moveOptions(fitler, 1);" value=" - " />[/code:1]

should be
[code:1]<input type=button onclick="moveOptions(filter, 1);" value=" - " />[/code:1]

Post edited by: ndee, at: 2008/12/09 00:35


Typo is a good find, thanks, commited to CB.

Now reading the rest B) , will probably do the commit only tomorrow, with fresh eyes :)

Beat - Community Builder Team Member

Before posting on forums: Read FAQ thoroughly -- Help us spend more time coding by helping others in this forum, many thanks :)
CB links: Our membership - CBSubs - Templates - Hosting - Forge - Send me a Private Message (PM) only for private/confidential info
Moderators: beatnantkrileon
Time to create page: 0.520 seconds
Facebook Twitter Google LinkedIn